Skip to content

Bug fix: binlog serialization of empty TEXT values#10621

Merged
fulghum merged 1 commit intomainfrom
fulghum/binlog_empty_text
Mar 3, 2026
Merged

Bug fix: binlog serialization of empty TEXT values#10621
fulghum merged 1 commit intomainfrom
fulghum/binlog_empty_text

Conversation

@fulghum
Copy link
Copy Markdown
Contributor

@fulghum fulghum commented Mar 3, 2026

This change fixes a bug that caused empty TEXT fields to trigger a panic when serialized to a binlog.

Related to: #10601

@coffeegoddd
Copy link
Copy Markdown
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
1283a89 ok 5937471
version total_tests
1283a89 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@fulghum DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 62.19 62.19 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 8b3e5ff 37.4 dolt 1283a89 37.13 -0.72

@fulghum fulghum requested a review from zachmu March 3, 2026 17:26
Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit ba778b2 into main Mar 3, 2026
40 of 43 checks passed
@fulghum fulghum deleted the fulghum/binlog_empty_text branch March 3, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants